datenba-ch/matrix-social-invites
2
0
Fork 0
Code Issues 1 Pull requests 14 Projects Releases Packages Wiki Activity Actions

Add release tag handling to deploy workflow #10

Open
florianbeisel wants to merge 1 commit from codex/update-github-actions-deploy-workflow-zcqyd6 into main
pull from: codex/update-github-actions-deploy-workflow-zcqyd6
merge into: datenba-ch:main
Conversation 2 Commits 1 Files changed 1 +8 -1
florianbeisel commented 2026-01-28 10:12:58 +01:00 (Migrated from github.com)
Copy link

Motivation

  • Enable CI to trigger on release tag pushes (e.g. v*) so releases can build and publish images from tags.
  • Ensure release/tag builds produce image tags named after the release (in addition to the sha-... tag) and that the deployment job runs for release tags as well as main.

Description

  • Updated on.push in .github/workflows/deploy.yml to include tag pattern "v*" so tag pushes trigger the workflow.
  • Added REF_NAME_SHORT (${{ github.ref_name }}) and a refs/tags/* branch in the build step so tagged releases add -t ${IMAGE}:${REF_NAME_SHORT} alongside the sha-... tag and still push to both ${INTERNAL_IMAGE} and ${GHCR_IMAGE}.
  • Removed the requirement that PR_NUMBER be present for tag builds by handling the refs/tags/* case separately.
  • Adjusted the deploy job if condition to run on refs/heads/main or tag refs via startsWith(github.ref, 'refs/tags/') so deploys occur for releases and main.

Testing

  • No automated tests were run because this is a CI workflow-only change; validation should be performed by observing the next tag or main push in CI execution.

Codex Task

### Motivation - Enable CI to trigger on release tag pushes (e.g. `v*`) so releases can build and publish images from tags. - Ensure release/tag builds produce image tags named after the release (in addition to the `sha-...` tag) and that the deployment job runs for release tags as well as `main`. ### Description - Updated `on.push` in `.github/workflows/deploy.yml` to include tag pattern `"v*"` so tag pushes trigger the workflow. - Added `REF_NAME_SHORT` (`${{ github.ref_name }}`) and a `refs/tags/*` branch in the build step so tagged releases add `-t ${IMAGE}:${REF_NAME_SHORT}` alongside the `sha-...` tag and still push to both `${INTERNAL_IMAGE}` and `${GHCR_IMAGE}`. - Removed the requirement that `PR_NUMBER` be present for tag builds by handling the `refs/tags/*` case separately. - Adjusted the `deploy` job `if` condition to run on `refs/heads/main` or tag refs via `startsWith(github.ref, 'refs/tags/')` so deploys occur for releases and main. ### Testing - No automated tests were run because this is a CI workflow-only change; validation should be performed by observing the next tag or main push in CI execution. ------ [Codex Task](https://chatgpt.com/codex/tasks/task_e_6979d1a777d4832ab712417e1d1c0d0b)
chatgpt-codex-connector[bot] commented 2026-01-28 10:13:03 +01:00 (Migrated from github.com)
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

You have reached your Codex usage limits for code reviews. You can see your limits in the [Codex usage dashboard](https://chatgpt.com/codex/settings/usage). To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your [settings](https://chatgpt.com/codex/settings/code-review).
changeset-bot[bot] commented 2026-01-28 13:18:58 +01:00 (Migrated from github.com)
Copy link

⚠️ No Changeset found

Latest commit: cff40145b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

### ⚠️ No Changeset found Latest commit: cff40145b1fb4b55313c63d914cdc9f83e33aed8 Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.** [Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). [Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/florianbeisel/forest-friend-invites/new/codex/update-github-actions-deploy-workflow-zcqyd6?filename=.changeset/sweet-apples-happen.md&value=---%0A%22%40fake-scope%2Ffake-pkg%22%3A%20patch%0A---%0A%0AAdd%20release%20tag%20handling%20to%20deploy%20workflow%0A)
This pull request has changes conflicting with the target branch.
  • .github/workflows/deploy.yml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin codex/update-github-actions-deploy-workflow-zcqyd6:codex/update-github-actions-deploy-workflow-zcqyd6
git switch codex/update-github-actions-deploy-workflow-zcqyd6

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff codex/update-github-actions-deploy-workflow-zcqyd6
git switch codex/update-github-actions-deploy-workflow-zcqyd6
git rebase main
git switch main
git merge --ff-only codex/update-github-actions-deploy-workflow-zcqyd6
git switch codex/update-github-actions-deploy-workflow-zcqyd6
git rebase main
git switch main
git merge --no-ff codex/update-github-actions-deploy-workflow-zcqyd6
git switch main
git merge --squash codex/update-github-actions-deploy-workflow-zcqyd6
git switch main
git merge --ff-only codex/update-github-actions-deploy-workflow-zcqyd6
git switch main
git merge codex/update-github-actions-deploy-workflow-zcqyd6
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
codex

   
dependencies
Pull requests that update a dependency file

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update javascript code

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
codex
dependencies
documentation
duplicate
enhancement
good first issue
help wanted
invalid
javascript
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
datenba-ch/matrix-social-invites!10
No description provided.